Skip to content

gh-101100: Fix all Sphinx warnings in Doc/library/subprocess.rst#139576

Merged
hugovk merged 1 commit into
python:mainfrom
StanFromIreland:subprocess-warnings
Oct 8, 2025
Merged

gh-101100: Fix all Sphinx warnings in Doc/library/subprocess.rst#139576
hugovk merged 1 commit into
python:mainfrom
StanFromIreland:subprocess-warnings

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Oct 4, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Oct 4, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Oct 4, 2025
StanFromIreland
StanFromIreland commented Oct 4, 2025
View reviewed changes
Comment thread Doc/library/subprocess.rst
Return ``(exitcode, output)`` of executing *cmd* in a shell.

Execute the string *cmd* in a shell with :meth:`Popen.check_output` and
Execute the string *cmd* in a shell with :func:`check_output` and

@StanFromIreland StanFromIreland Oct 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the source (and the fact that no such method exists):

cpython/Lib/subprocess.py

Lines 676 to 677 in 0b21682

data = check_output(cmd, shell=True, text=True, stderr=STDOUT,
encoding=encoding, errors=errors)

vstinner
vstinner approved these changes Oct 8, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 99fd525 into python:main Oct 8, 2025
38 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Oct 8, 2025
@hugovk hugovk added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 8, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@StanFromIreland @miss-islington
pythongh-101100: Fix all Sphinx warnings in `Doc/library/subprocess.r…
f25356f 
…st` (pythonGH-139576)

(cherry picked from commit 99fd525)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@StanFromIreland @miss-islington
pythongh-101100: Fix all Sphinx warnings in `Doc/library/subprocess.r…
cea177e 
…st` (pythonGH-139576)

(cherry picked from commit 99fd525)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139787 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
@bedevere-app

bedevere-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139788 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2025
@StanFromIreland StanFromIreland deleted the subprocess-warnings branch October 8, 2025 15:28
@StanFromIreland

StanFromIreland commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

Thanks guys!

hugovk pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @StanFromIreland
[3.14] gh-101100: Fix all Sphinx warnings in `Doc/library/subprocess.…
4e3fc92 
…rst` (GH-139576) (#139787)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
hugovk added a commit that referenced this pull request Nov 22, 2025
@miss-islington @StanFromIreland @hugovk
[3.13] gh-101100: Fix all Sphinx warnings in `Doc/library/subprocess.…
616117b 
…rst` (GH-139576) (#139788)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @vstinner @hugovk